Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release 1.10.1 #11253

Merged
merged 1 commit into from
Apr 23, 2024
Merged

release 1.10.1 #11253

merged 1 commit into from
Apr 23, 2024

Conversation

strongjz
Copy link
Member

No description provided.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2024
@strongjz strongjz marked this pull request as ready for review April 11, 2024 15:45
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/docs and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 11, 2024
@k8s-ci-robot k8s-ci-robot added area/helm Issues or PRs related to helm charts approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 11, 2024
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 11, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 11, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit fab36c0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/662127580c7b940008d62135

@Gacko
Copy link
Member

Gacko commented Apr 15, 2024

Wouldn't merging that to main release the chart from main? We have some features there that do not work with the image being built from release-1.10 plus it wouldn't be a patch release then.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2024
Gacko
Gacko reviewed Apr 15, 2024
View reviewed changes
charts/ingress-nginx/Chart.yaml Outdated Show resolved Hide resolved
charts/ingress-nginx/changelog/helm-chart-4.10.1.md Outdated Show resolved Hide resolved
changelog/controller-1.10.1.md Show resolved Hide resolved
@strongjz
Copy link
Member Author

Wouldn't merging that to main release the chart from main? We have some features there that do not work with the image being built from release-1.10 plus it wouldn't be a patch release then.

/hold

That might be an issue, we always PR to main for a release.

#11039
#10469

@Gacko
Copy link
Member

Gacko commented Apr 15, 2024

Yeah, I already assumed that. Is it possible to PR against the release branch? Otherwise: YOLO, care later...

@strongjz
Copy link
Member Author

Yeah, I already assumed that. Is it possible to PR against the release branch? Otherwise: YOLO, care later...

CI isn't passing at all, so definitely don't want to release it if that happens.

@strongjz
Release controller 1.10.1
fab36c0 
Signed-off-by: James Strong <[email protected]>
@strongjz strongjz changed the title release 1.10.1 helm 4.10.1 release 1.10.1 Apr 18, 2024
@strongjz strongjz mentioned this pull request Apr 18, 2024
Merged
@Gacko
Copy link
Member

Gacko commented Apr 18, 2024

/triage accepted
/kind feature
/priority important-soon
/cherry-pick release-1.10

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/triage accepted
/kind feature
/priority important-soon
/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Apr 18, 2024
@Gacko
Copy link
Member

Gacko commented Apr 18, 2024

So as long as the images we are referencing here are actually around and working, I don't see a reason not to merge that as it only releases the controller and we are releasing the chart apart from that. Actually it would be better to have that merged before the chart release. WDYT?

@Gacko
Copy link
Member

Gacko commented Apr 19, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@strongjz
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit 51847ac into kubernetes:main Apr 23, 2024
7 checks passed
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 23, 2024
Merged
@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: new pull request created: #11298

In response to this:

/triage accepted
/kind feature
/priority important-soon
/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gacko Gacko Gacko left review comments

@ubergesundheit ubergesundheit Awaiting requested review from ubergesundheit

@tao12345666333 tao12345666333 Awaiting requested review from tao12345666333

Assignees

@Gacko Gacko

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docs area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@strongjz @k8s-ci-robot @Gacko @k8s-infra-cherrypick-robot